Description
In the Linux kernel, the following vulnerability has been resolved: ovl: set the revalidate flags after d_instantiate() stat() of a file on an overlayfs mount triggers a kernel warning and fails with ECHILD if another task is creating that file at the same time. This happens on an overlay with a FUSE upper layer, which is the layer where overlayfs creates new files. Write access to a directory on such an overlay is all a user needs to run the two tasks. The revalidate flags are DCACHE_OP_REVALIDATE and DCACHE_OP_WEAK_REVALIDATE. They tell path walk to call ->d_revalidate() or ->d_weak_revalidate() on a dentry, so that the filesystem can check that the cached dentry is still valid. An overlay dentry only has one of these flags if a dentry in one of its layers has it. FUSE dentries have the first one. When a flag is set on an overlay dentry, path walk calls ovl_dentry_revalidate_common(). That function only expects a dentry without an inode in RCU walk, while the dentry is being destroyed. For such a dentry outside of RCU walk, it hits a WARN_ON() and returns -ECHILD. So a negative overlay dentry must never have the flags set. ovl_instantiate() breaks this rule. When a task creates a file, the overlay dentry for the new name is hashed but still negative. ovl_instantiate() then works in this order: - It copies the flags from the new upper dentry to the overlay dentry. - It calls ovl_get_inode(), which can sleep in a getxattr request to the FUSE server. - Only then does it call d_instantiate(). A second task that looks up the name between the first step and the last finds a negative dentry with the flags set and revalidates it. Reproduced with a FUSE server that delays its getxattr reply: stat() of a name that was being created hit the WARN_ON() and failed with ECHILD. Fix this by setting the flags after d_instantiate().
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
bccece1ead368149f90e05ad104dfbfda4422f5d to < e876482d955476d0c066afda8273bfd38e0f65beaffectedbccece1ead368149f90e05ad104dfbfda4422f5d to < 7ecbeb1a84f2d099012ccd95a8a7588e1306cc46affectedbccece1ead368149f90e05ad104dfbfda4422f5d to < 3d92153206cebe95dc873a4b2b3d506ddf2271e7affectedbccece1ead368149f90e05ad104dfbfda4422f5d to < 75e89c0055c1d7f7eeb462995f11253ca5864f79affected
Linux Linux
Default version status: affected
5.7affected0 to < 5.7unaffected6.12.117 to ≤ 6.12.*unaffected6.18.61 to ≤ 6.18.*unaffected7.3.2 to ≤ 7.3.*unaffected7.4-rc1 to ≤ *unaffected