Description
In the Linux kernel, the following vulnerability has been resolved: KVM: guest_memfd: take the invalidate lock when unbinding a dying file kvm_gmem_unbind() takes mapping->invalidate_lock only if the get_file_active() succeeds. When the guest_memfd file is dying, its reference count is already zero so get_file_active fails and the binding is removed without holding the invalidate lock. kvm_gmem_invalidate_{start,end}() checks f->bindings independently to decide whether to begin or end KVM MMU invalidation. So, the bindings must therefore remain stable between the two calls. Otherwise, unbind can remove a binding after start increments mmu_invalidate_in_progress, but before end finds the binding and decrements it. Example, unbind race with memory failure: CPU 0: memory failure CPU 1: memslot delete ---------------------------------- --------------------------- (guest_memfd file is dying) kvm_gmem_error_folio() kvm_gmem_invalidate_start() finds binding mmu_invalidate_in_progress++ kvm_gmem_unbind() get_file_active() fails removes binding kvm_gmem_invalidate_end() no binding found counter stays elevated mmu_invalidate_retry() then returns 1 forever, so guest page faults retry without ever installing a mapping and the guest hangs. Remove the distinction between live and dying files in the unbind path. Always use slot->gmem.file and take the invalidate lock when it's non-NULL. Normal unbind callers hold slots_lock, which prevents release from clearing the pointer or freeing the file state until unbind completes. Final VM teardown can only see a NULL pointer because guest_memfd pins the KVM until release has cleared all bindings.
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
a8ac2bd0f98e1a230f1eb3260fa552bf2ef1753b to < 4ae4316682cdc78d8f5a856ab0712a8281f211caaffectedae431059e75d36170a5ae6b44cc4d06d43613215 to < 3af94f4e3526efdf52d84d7ba8d9fb8e8facb93aaffectedae431059e75d36170a5ae6b44cc4d06d43613215 to < 024be82ac4c4df650cc6daca6d7db79daee95470affectedae431059e75d36170a5ae6b44cc4d06d43613215 to < 0ee2c883b62deb74d8c43007e8049dc006d3a2fbaffected393893693a523e053f84d69320d090b93503f79faffected6.12.59 to < 6.12.118affected6.17.9 to < 6.18affected
Linux Linux
Default version status: affected
6.18affected0 to < 6.18unaffected6.12.118 to ≤ 6.12.*unaffected6.18.64 to ≤ 6.18.*unaffected7.3.2 to ≤ 7.3.*unaffected7.4-rc1 to ≤ *unaffected