Description
In the Linux kernel, the following vulnerability has been resolved: keys: Protect the read method check against type removal keyctl_read_key() checks key->type->read without holding key->sem. A reference keeps the key alive, but does not pin the module containing its type. A surviving RxRPC key can therefore be read while AF_RXRPC is being unloaded: KEYCTL_READ task Module unload and key GC ---------------- ------------------------ lookup_user_key() permission / possession checks load key->type af_rxrpc_exit() unregister_key_type() GC: down_write(key->sem) GC: retype to key_type_dead GC: up_write(key->sem) unregister_key_type() returns free_module() read saved type's read member The final access can read freed module storage. The read invocation in __keyctl_read_key() is already protected by key->sem, but the earlier method check is outside that critical section. Move the method check into __keyctl_read_key(), after key_validate() and under its existing read hold on key->sem. The check and invocation then use the same protected type for length queries and every read retry. The GC cannot retype the key until the semaphore is released, and type unregistration waits for that GC pass before the module can be freed. Return -EOPNOTSUPP when validation succeeds and the type has no read method. A temporary buffer may now be allocated before this result; allocation and copying to userspace remain outside the semaphore.
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
d3ec10aa95819bff18a0d936b18884c7816d0914 to < e5f830ae6611cddbfc504c43f14155f60b63206aaffectedd3ec10aa95819bff18a0d936b18884c7816d0914 to < ff11cfed85cbfdd7fe1185ebd18d2c7a8353ad8daffectedd3ec10aa95819bff18a0d936b18884c7816d0914 to < 1486caee47b4909f52835a957c3293e970113e44affectedd3ec10aa95819bff18a0d936b18884c7816d0914 to < ff44f1b303aa76a818d898e85c56ed4852c031e2affectedd3ec10aa95819bff18a0d936b18884c7816d0914 to < 6a36e2a1a017c51f8a8ad2a094566bad97c46a9baffectedd3ec10aa95819bff18a0d936b18884c7816d0914 to < 3edc064069d07e7d37359fcb4d03d3bab15ee3abaffectedd3ec10aa95819bff18a0d936b18884c7816d0914 to < cf1af7df80e38bf58bd74c2cccce32fcbd1a596aaffectedd3ec10aa95819bff18a0d936b18884c7816d0914 to < e2a2deda08d91644f5e30c17d267b1cdc5f124b2affectedd3ec10aa95819bff18a0d936b18884c7816d0914 to < 925c84e3cc21caf09de92d9bcafab0147790debfaffected7fa67aa30509ad0da72ac0f757aa76e53c0ea3deaffected18779eac17b5df9dff57138d07631573553a41d4affectedf1afcf9488fc45765e20e2047d3b776981900e0baffected212d3adb1af4e34acb158d6c6def370016a1011daffected4.14.177 to < 4.15affected4.19.118 to < 4.20affected5.4.35 to < 5.5affected5.6.7 to < 5.7affected
Linux Linux
Default version status: affected
5.7affected0 to < 5.7unaffected5.10.273 to ≤ 5.10.*unaffected5.15.224 to ≤ 5.15.*unaffected6.1.191 to ≤ 6.1.*unaffected6.6.161 to ≤ 6.6.*unaffected6.12.115 to ≤ 6.12.*unaffected6.18.60 to ≤ 6.18.*unaffected7.2.14 to ≤ 7.2.*unaffected7.3.1 to ≤ 7.3.*unaffected7.4-rc1 to ≤ *unaffected
References
- https://git.kernel.org/stable/c/e5f830ae6611cddbfc504c43f14155f60b63206a ↗
- https://git.kernel.org/stable/c/ff11cfed85cbfdd7fe1185ebd18d2c7a8353ad8d ↗
- https://git.kernel.org/stable/c/1486caee47b4909f52835a957c3293e970113e44 ↗
- https://git.kernel.org/stable/c/ff44f1b303aa76a818d898e85c56ed4852c031e2 ↗
- https://git.kernel.org/stable/c/6a36e2a1a017c51f8a8ad2a094566bad97c46a9b ↗
- https://git.kernel.org/stable/c/3edc064069d07e7d37359fcb4d03d3bab15ee3ab ↗
- https://git.kernel.org/stable/c/cf1af7df80e38bf58bd74c2cccce32fcbd1a596a ↗
- https://git.kernel.org/stable/c/e2a2deda08d91644f5e30c17d267b1cdc5f124b2 ↗
- https://git.kernel.org/stable/c/925c84e3cc21caf09de92d9bcafab0147790debf ↗