Description
In the Linux kernel, the following vulnerability has been resolved: net/rds: use wq_has_sleeper() in release_in_xmit() release_in_xmit() clears RDS_IN_XMIT with clear_bit_unlock() and then checks waitqueue_active() to decide whether anyone needs waking. clear_bit_unlock() is only a release operation: it orders the critical section before the bit clear, but does not order the subsequent plain load of the wait queue head after it. The waiter side does the mirror image - it adds itself to the wait queue and then tests the bit. That is the classic store-buffering pattern: the releasing CPU can read the wait queue as empty while the waiting CPU still reads the bit as set, so the sleeper is never woken. The waiters are rds_conn_shutdown() and rds_tcp_reset_callbacks(), both in uninterruptible wait_event() with no timeout. A lost wake-up strands the shutdown worker on its single-threaded workqueue until some other sender releases the bit again - and on a connection that is being torn down precisely because it failed, there may never be another sender. The barrier used to be there: release_in_xmit() did clear_bit() followed by smp_mb__after_atomic() until commit 1422f28826d2 ("rds: introduce acquire/release ordering in acquire/release_in_xmit()") folded both into clear_bit_unlock(), which strengthened the lock hand-off but silently dropped the full barrier the wake-up check depends on. The refill counterpart, release_refill() in net/rds/ib_recv.c, still carries its smp_mb__after_atomic() for exactly this reason. Use wq_has_sleeper(), which is waitqueue_active() preceded by the required full barrier.
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
1e1e4316fcaeb9cd6bc56c91127e88625237dd44 to < 6f552364d97cf4005c7a58f11c9f79e14e269865affected8c378cc522aedd5fa5aa53486b43a4d552fbbd5c to < a94b1dfc82454c5bc068e71c25393af674daf63baffected52287ed416a10bc3d3e204a3186d9509ab3ee634 to < 5a806ed1eb46850ca4159a18b2a8c4b70f0c1341affected4a4dffdff9ea6201665f5d0a5042011d09bd527f to < 3d401934b7edb3ccb07d982dabadd04c45ee307caffected1422f28826d2a0c11e5240b3e951c9e214d8656e to < ed7ee0cd0e136d02f87f13181b1a89880463c7e9affected1422f28826d2a0c11e5240b3e951c9e214d8656e to < a269795107f45adc95975a83324f8fef40bec4ceaffected1422f28826d2a0c11e5240b3e951c9e214d8656e to < 3764627b30a283e611e652c4a2bb8cdc74a75a99affected1422f28826d2a0c11e5240b3e951c9e214d8656e to < 6d0c8b7073913011459cf968cbbadd341e166bc3affectedbec6c4ce1169a565c58c347d5d0ac22e46d507d6affectedf781fb5177cdfd9a6c98cd94e30275457c6461acaffected917135195200e20e5244b9c3f2bb40f3d5e02510affectedd792459a6e2ae21c7f5107babd63e52e4c5ab93aaffected5.10.214 to < 5.10.271affected5.15.153 to < 5.15.222affected6.1.83 to < 6.1.189affected6.6.23 to < 6.6.158affected4.19.311 to < 4.20affected5.4.273 to < 5.5affected6.7.11 to < 6.8affected6.8.2 to < 6.9affected
Linux Linux
Default version status: affected
6.9affected0 to < 6.9unaffected5.10.271 to ≤ 5.10.*unaffected5.15.222 to ≤ 5.15.*unaffected6.1.189 to ≤ 6.1.*unaffected6.6.158 to ≤ 6.6.*unaffected6.12.111 to ≤ 6.12.*unaffected6.18.53 to ≤ 6.18.*unaffected7.2.7 to ≤ 7.2.*unaffected7.3 to ≤ *unaffected
References
- https://git.kernel.org/stable/c/6f552364d97cf4005c7a58f11c9f79e14e269865 ↗
- https://git.kernel.org/stable/c/a94b1dfc82454c5bc068e71c25393af674daf63b ↗
- https://git.kernel.org/stable/c/5a806ed1eb46850ca4159a18b2a8c4b70f0c1341 ↗
- https://git.kernel.org/stable/c/3d401934b7edb3ccb07d982dabadd04c45ee307c ↗
- https://git.kernel.org/stable/c/ed7ee0cd0e136d02f87f13181b1a89880463c7e9 ↗
- https://git.kernel.org/stable/c/a269795107f45adc95975a83324f8fef40bec4ce ↗
- https://git.kernel.org/stable/c/3764627b30a283e611e652c4a2bb8cdc74a75a99 ↗
- https://git.kernel.org/stable/c/6d0c8b7073913011459cf968cbbadd341e166bc3 ↗