Description
In the Linux kernel, the following vulnerability has been resolved: smb: client: fail DACL rewrite when the new DACL exceeds 64K replace_sids_and_copy_aces() and set_chmod_dacl() accumulate the size of the DACL they build in a u16. That accumulator can wrap. validate_dacl() caps num_aces at (dacl_size - sizeof(struct smb_acl)) / 20, i.e. 3276 for a maximally sized DACL, while each rewritten ACE can grow to sizeof(struct smb_ace) (76 bytes) once its SID is replaced with one carrying SID_MAX_SUB_AUTHORITIES sub-authorities. The worst case is therefore sizeof(struct smb_acl) + 3276 * 76 = 248984 bytes, far beyond what a u16 can hold. A wraparound is reached with 863 ACEs. After the wraparound, ndacl_ptr->size becomes meaningless and the offset will point anywhere in the ACE array. As a result, we will see corruption of the DACL, which then gets sent to the server. This is not an out-of-bounds write as the allocation now covers the worst-case expansion, so writes will always go into the buffer. Adjust the code to use a u32 internally and return -EOVERFLOW in the overflow case. The operation must be refused, because a DACL can only hold 2^16-1 bytes on the wire and larger DACLs cannot be represented. set_chmod_dacl() carries the same pattern and is fixed the same way. It only wraps once the source DACL comes within roughly 380 bytes of the 64K ceiling, but the failure mode is identical.
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
f5065508897a922327f32223082325d10b069ebc to < 284877c6189fda1ac3d81771dd8482660a0c7dc1affectedf5065508897a922327f32223082325d10b069ebc to < d433376abc47e10870ae732f89c7c1a60b199a0caffectedf5065508897a922327f32223082325d10b069ebc to < 2ef532a01f44687f5b95001e88247cf05bff9892affectedf5065508897a922327f32223082325d10b069ebc to < ee13d687d06a6fbb2008625dd560c654231b28e0affectedf5065508897a922327f32223082325d10b069ebc to < d05045177a855386bca5e1909e08d06290e6e3b3affected
Linux Linux
Default version status: affected
5.12affected0 to < 5.12unaffected6.6.160 to ≤ 6.6.*unaffected6.12.112 to ≤ 6.12.*unaffected6.18.53 to ≤ 6.18.*unaffected7.2.7 to ≤ 7.2.*unaffected7.3 to ≤ *unaffected
References
- https://git.kernel.org/stable/c/284877c6189fda1ac3d81771dd8482660a0c7dc1 ↗
- https://git.kernel.org/stable/c/d433376abc47e10870ae732f89c7c1a60b199a0c ↗
- https://git.kernel.org/stable/c/2ef532a01f44687f5b95001e88247cf05bff9892 ↗
- https://git.kernel.org/stable/c/ee13d687d06a6fbb2008625dd560c654231b28e0 ↗
- https://git.kernel.org/stable/c/d05045177a855386bca5e1909e08d06290e6e3b3 ↗