Description
In the Linux kernel, the following vulnerability has been resolved: net/smc: free stashed qentry before overwrite in REQ_ADD_LINK to ADD_LINK transition When smc_llc_event_handler() transitions the local LLC flow from SMC_LLC_FLOW_REQ_ADD_LINK to SMC_LLC_FLOW_ADD_LINK on arrival of an ADD_LINK request, it calls smc_llc_flow_qentry_set() unconditionally: if (lgr->llc_flow_lcl.type == SMC_LLC_FLOW_REQ_ADD_LINK) { lgr->llc_flow_lcl.type = SMC_LLC_FLOW_ADD_LINK; smc_llc_flow_qentry_set(&lgr->llc_flow_lcl, qentry); ... } A CONFIRM_LINK or ADD_LINK_CONT arriving while flow->type is SMC_LLC_FLOW_REQ_ADD_LINK is stashed into flow->qentry via the SMC_LLC_CONFIRM_LINK / SMC_LLC_ADD_LINK_CONT handler (which stores into flow->qentry for any non-NONE flow type). When the subsequent ADD_LINK arrives, the REQ_ADD_LINK branch overwrites flow->qentry with the new pointer without first freeing the stashed allocation, leaking one kmalloc object. The stashed entry has no consumer: smc_llc_wait() is only called from llc_add_link_work, which is not yet scheduled while the flow type remains REQ_ADD_LINK. No waiter is sleeping on llc_msg_waiter at this point. It is safe to unconditionally free any stashed qentry before the overwrite. Call smc_llc_flow_qentry_del() before smc_llc_flow_qentry_set() in the REQ_ADD_LINK branch. smc_llc_flow_qentry_del() already checks flow->qentry before freeing, so the normal path where no entry is stashed is a no-op.
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
b4ba4652b3f8b7c9bbb5786f8acf4724bdab2196 to < 7dd55348c0d9399a9448847819e9f3904ae507adaffectedb4ba4652b3f8b7c9bbb5786f8acf4724bdab2196 to < 056395acb7041b3a1f2baa08d89a1938a8b8776aaffectedb4ba4652b3f8b7c9bbb5786f8acf4724bdab2196 to < b08aacfb226a840628151643b6a34eecf545d311affectedb4ba4652b3f8b7c9bbb5786f8acf4724bdab2196 to < 0fb9a513766071ea9d5f3bf988e39241b8e9ee3baffectedb4ba4652b3f8b7c9bbb5786f8acf4724bdab2196 to < e25a602c45c76a7130878db72bcf6f76df04bf85affectedb4ba4652b3f8b7c9bbb5786f8acf4724bdab2196 to < 036322025d6e440cb75fc6fecbba9a16b271a2aeaffected
Linux Linux
Default version status: affected
5.16affected0 to < 5.16unaffected6.1.188 to ≤ 6.1.*unaffected6.6.157 to ≤ 6.6.*unaffected6.12.110 to ≤ 6.12.*unaffected6.18.52 to ≤ 6.18.*unaffected7.2.6 to ≤ 7.2.*unaffected7.3 to ≤ *unaffected
References
- https://git.kernel.org/stable/c/7dd55348c0d9399a9448847819e9f3904ae507ad ↗
- https://git.kernel.org/stable/c/056395acb7041b3a1f2baa08d89a1938a8b8776a ↗
- https://git.kernel.org/stable/c/b08aacfb226a840628151643b6a34eecf545d311 ↗
- https://git.kernel.org/stable/c/0fb9a513766071ea9d5f3bf988e39241b8e9ee3b ↗
- https://git.kernel.org/stable/c/e25a602c45c76a7130878db72bcf6f76df04bf85 ↗
- https://git.kernel.org/stable/c/036322025d6e440cb75fc6fecbba9a16b271a2ae ↗