Description
In the Linux kernel, the following vulnerability has been resolved: SUNRPC: harden gss_krb5_unwrap_v2 against short tokens gss_krb5_unwrap_v2() reads the EC and RRC header fields at ptr+4 and ptr+6 before validating that the token is at least GSS_KRB5_TOK_HDR_LEN (16) bytes long, and its rotate_left() helper passes buf->len - base to xdr_buf_subsegment() without verifying that base <= buf->len. When a caller hands in a sub-16-byte token, or a token whose declared len leaves base past the end of the buffer, three distinct failures follow: gss_krb5_unwrap_v2(offset, len, buf) ptr = buf->head[0].iov_base + offset ec = *(ptr + 4) /* OOB read on short head */ rrc = *(ptr + 6) /* OOB read on short head */ rotate_left(offset + 16, buf, rrc) xdr_buf_subsegment(buf, &subbuf, base, buf->len - base) /* u32 wrap when base > len */ _rotate_left(&subbuf, shift) shift %= buf->len /* divide-by-zero when base == len */ After decryption, the cleanup arithmetic has the same shape: movelen = min_t(unsigned int, buf->head[0].iov_len, len); movelen -= offset + GSS_KRB5_TOK_HDR_LEN + headskip; BUG_ON(offset + GSS_KRB5_TOK_HDR_LEN + headskip + movelen > buf->head[0].iov_len); The BUG_ON re-adds the value just subtracted, so it reduces to min(A, B) > A and is permanently false; it cannot catch the unsigned underflow of movelen, which then drives a ~UINT_MAX-byte memmove(). Add four defense-in-depth guards inside the unwrap core so it is safe regardless of what its callers validate: - reject tokens with len - offset < GSS_KRB5_TOK_HDR_LEN before touching ptr+4/ptr+6; - bail from rotate_left() when buf->len <= base, covering both the underflow and zero-length cases; - return early from _rotate_left() when buf->len is zero, so the shift %= buf->len modulo cannot fault; - replace the dead BUG_ON with a live check that returns GSS_S_DEFECTIVE_TOKEN before the movelen subtraction.
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
de9c17eb4a912c9028f7b470eb80815144883b26 to < 299d281c7225ded15b28cb861a98d818d82787fcaffectedde9c17eb4a912c9028f7b470eb80815144883b26 to < 84ddbc8d084c0251d534f14f5d1a7da05be56404affectedde9c17eb4a912c9028f7b470eb80815144883b26 to < 075d7cfc4df8c54cb202ba8b28420370c03ba9b6affectedde9c17eb4a912c9028f7b470eb80815144883b26 to < f2591660e0eb263c9415bf0d0bb1b111e62df7a4affectedde9c17eb4a912c9028f7b470eb80815144883b26 to < dddcb0f4b7e27fac16a78ea9a1c8ec2e8a241087affectedde9c17eb4a912c9028f7b470eb80815144883b26 to < 806584a4b67a7233870c33e5b8f872e76dd02988affectedde9c17eb4a912c9028f7b470eb80815144883b26 to < a7894e10572d53eb10109b8d07459cc8d3435811affectedde9c17eb4a912c9028f7b470eb80815144883b26 to < 6959297aaa9572783d620a226d73c3fb94494888affected
Linux Linux
Default version status: affected
2.6.35affected0 to < 2.6.35unaffected5.10.270 to ≤ 5.10.*unaffected5.15.221 to ≤ 5.15.*unaffected6.1.188 to ≤ 6.1.*unaffected6.6.157 to ≤ 6.6.*unaffected6.12.109 to ≤ 6.12.*unaffected6.18.50 to ≤ 6.18.*unaffected7.2.4 to ≤ 7.2.*unaffected7.3 to ≤ *unaffected
References
- https://git.kernel.org/stable/c/299d281c7225ded15b28cb861a98d818d82787fc ↗
- https://git.kernel.org/stable/c/84ddbc8d084c0251d534f14f5d1a7da05be56404 ↗
- https://git.kernel.org/stable/c/075d7cfc4df8c54cb202ba8b28420370c03ba9b6 ↗
- https://git.kernel.org/stable/c/f2591660e0eb263c9415bf0d0bb1b111e62df7a4 ↗
- https://git.kernel.org/stable/c/dddcb0f4b7e27fac16a78ea9a1c8ec2e8a241087 ↗
- https://git.kernel.org/stable/c/806584a4b67a7233870c33e5b8f872e76dd02988 ↗
- https://git.kernel.org/stable/c/a7894e10572d53eb10109b8d07459cc8d3435811 ↗
- https://git.kernel.org/stable/c/6959297aaa9572783d620a226d73c3fb94494888 ↗