Description
In the Linux kernel, the following vulnerability has been resolved: dm thin metadata: fix metadata snapshot consistency on commit failure __reserve_metadata_snap() and __release_metadata_snap() modify the superblock's held_root directly in the block_manager's buffer. If the subsequent metadata commit fails, the held_root gets flushed to disk through the abort_transaction path, resulting in inconsistent metadata. Reproducer 1: __reserve_metadata_snap() 1. Create a 2 MiB metadata device and make the region after the 14th block inaccessible, to trigger metadata commit failure in the subsequent reserve_metadata_snap operation. The 14th block will be the shadow destination for the index block. dmsetup create tmeta --table "0 112 linear /dev/sdc 0 112 3984 error" 2. Create a 16 MiB thin-pool dmsetup create tdata --table "0 32768 zero" dd if=/dev/zero of=/dev/mapper/tmeta bs=4k count=1 dmsetup create tpool --table "0 32768 thin-pool /dev/mapper/tmeta \ /dev/mapper/tdata 128 0 1 skip_block_zeroing" 3. Take a metadata snapshot to trigger metadata commit failure and transaction abort. However, the held_root is written to disk, breaking metadata consistency. dmsetup message tpool 0 "reserve_metadata_snap" thin_check v1.2.2 result: Bad reference count for metadata block 6. Expected 2, but space map contains 1. Bad reference count for metadata block 7. Expected 2, but space map contains 1. Bad reference count for metadata block 13. Expected 1, but space map contains 0. Reproducer 2: __release_metadata_snap() 1. Create a 2 MiB metadata device and make the region after the 16th block inaccessible, to trigger metadata commit failure in the subsequent release_metadata_snap operation. The 16th block will be the shadow destination for the index block. dmsetup create tmeta --table "0 128 linear /dev/sdc 0 128 3968 error" 2. Create a 16 MiB thin-pool dmsetup create tdata --table "0 32768 zero" dd if=/dev/zero of=/dev/mapper/tmeta bs=4k count=1 dmsetup create tpool --table "0 32768 thin-pool /dev/mapper/tmeta \ /dev/mapper/tdata 128 0 1 skip_block_zeroing" 3. Reserve then release the metadata snapshot, to trigger metadata commit failure and transaction abort. The held_root gets removed from the on-disk superblock, causing inconsistent metadata. dmsetup message tpool 0 "reserve_metadata_snap" dmsetup message tpool 0 "release_metadata_snap" thin_check v1.2.2 result: Bad reference count for metadata block 6. Expected 1, but space map contains 2. Bad reference count for metadata block 7. Expected 1, but space map contains 2. 1 metadata blocks have leaked. Fix by deferring the held_root update to commit time. Additionally, move the existing-snapshot check in __reserve_metadata_snap before the shadow operation to avoid unnecessary work. In __release_metadata_snap, clear pmd->held_root before btree deletion so partial failure leaks blocks rather than leaving a stale reference, and unlock the snapshot block before decrementing its refcount.
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
991d9fa02da0dd1f843dc011376965e0c8c6c9b5 to < 4af993468193cf4cd32ba5748786e7801945f7d2affected991d9fa02da0dd1f843dc011376965e0c8c6c9b5 to < abf2fae92cbe68945028987d498cc72f8f0e23a8affected991d9fa02da0dd1f843dc011376965e0c8c6c9b5 to < 5efb1a7734ed4035fa4fdc3716bdb84621f27cf6affected991d9fa02da0dd1f843dc011376965e0c8c6c9b5 to < 3dc9ae1029320d77472c44965e572f176949cd63affected991d9fa02da0dd1f843dc011376965e0c8c6c9b5 to < b5f9a31c51cbb374a1713c3494f8660ab070f035affected991d9fa02da0dd1f843dc011376965e0c8c6c9b5 to < 7f76245960a332f39b08cc556e675d1765dc5bbbaffected991d9fa02da0dd1f843dc011376965e0c8c6c9b5 to < 9f1a0d27586ceab055e6b050e3731ce3c6b2c4f0affected991d9fa02da0dd1f843dc011376965e0c8c6c9b5 to < 5bcd4d3058ebaf46ad2e163829d87dd4870c7a45affected
Linux Linux
Default version status: affected
3.2affected0 to < 3.2unaffected5.10.261 to ≤ 5.10.*unaffected5.15.212 to ≤ 5.15.*unaffected6.1.178 to ≤ 6.1.*unaffected6.6.145 to ≤ 6.6.*unaffected6.12.97 to ≤ 6.12.*unaffected6.18.40 to ≤ 6.18.*unaffected7.1.5 to ≤ 7.1.*unaffected7.2 to ≤ *unaffected
References
- https://git.kernel.org/stable/c/4af993468193cf4cd32ba5748786e7801945f7d2 ↗
- https://git.kernel.org/stable/c/abf2fae92cbe68945028987d498cc72f8f0e23a8 ↗
- https://git.kernel.org/stable/c/5efb1a7734ed4035fa4fdc3716bdb84621f27cf6 ↗
- https://git.kernel.org/stable/c/3dc9ae1029320d77472c44965e572f176949cd63 ↗
- https://git.kernel.org/stable/c/b5f9a31c51cbb374a1713c3494f8660ab070f035 ↗
- https://git.kernel.org/stable/c/7f76245960a332f39b08cc556e675d1765dc5bbb ↗
- https://git.kernel.org/stable/c/9f1a0d27586ceab055e6b050e3731ce3c6b2c4f0 ↗
- https://git.kernel.org/stable/c/5bcd4d3058ebaf46ad2e163829d87dd4870c7a45 ↗