Description
In the Linux kernel, the following vulnerability has been resolved: mm/damon/ops-common: handle extreme intervals in damon_hot_score() Fix three issues in damon_hot_score() that comes from wrong handling of extreme (zero or too high) monitoring intervals user setup. When the user sets sampling interval zero, damon_max_nr_accesses(), which is called from damon_hot_score(), causes a divide-by-zero. Needless to say, it is a problem. When the user sets the aggregation interval zero, the function returns zero. It is wrong, since the real maximum nr_acceses in the setup should be one. Worse yet, it can cause another divide-by-zero from its caller, damon_hot_score(), since it uses damon_max_nr_accesses() return value as a denominator. When the user sets the aggregation interval very high, damon_hot_score() could return a value out of [0, DAMOS_MAX_SCORE] range. Since the return value is used as an index to the regions_score_histogram array, which is DAMOS_MAX_SCORE+1 size, it causes out of bounds array access. The issues can be relatively easily reproduced like below. The sysfs write permission is required, though. # ./damo start --damos_action lru_prio --damos_quota_space 100M \ --damos_quota_interval 1s # cd /sys/kernel/mm/damon/admin/kdamonds/0 # echo 0 > contexts/0/monitoring_attrs/intervals/sample_us # echo 0 > contexts/0/monitoring_attrs/intervals/aggr_us # echo commit > state # dmesg [...] [ 131.329762] Oops: divide error: 0000 [#1] SMP NOPTI [...] [ 131.336089] RIP: 0010:damon_hot_score+0x27/0xd0 [...] Fix the divide-by-zero intervals problems by explicitly handling the zero intervals in damon_max_nr_accesses(). Fix the out-of-bound array access by applying [0, DAMOS_MAX_SCORE] bounds before returning from damon_hot_score(). The issue was discovered [1] by Sashiko.
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
198f0f4c58b9f481e4e51c8c70a6ab9852bbab7f to < 58321b4e6e4f0f412069ab27ccdd56292757343aaffected198f0f4c58b9f481e4e51c8c70a6ab9852bbab7f to < 74fef68d521150281e36cdaa20e9e1ee3e3aa146affected198f0f4c58b9f481e4e51c8c70a6ab9852bbab7f to < ef2ae10a4582bc92b7e944181bbd2f87f3d30f3aaffected198f0f4c58b9f481e4e51c8c70a6ab9852bbab7f to < 9c8f31eaae6140ecadec0c07320498a944556de2affected198f0f4c58b9f481e4e51c8c70a6ab9852bbab7f to < 76e415ea88d20f022ed5cfcf78c50e156a267e91affected198f0f4c58b9f481e4e51c8c70a6ab9852bbab7f to < 35d4a3cf70a855b50e53189ac2f8463e20a02046affected
Linux Linux
Default version status: affected
5.16affected0 to < 5.16unaffected6.1.178 to ≤ 6.1.*unaffected6.6.145 to ≤ 6.6.*unaffected6.12.96 to ≤ 6.12.*unaffected6.18.39 to ≤ 6.18.*unaffected7.1.4 to ≤ 7.1.*unaffected7.2 to ≤ *unaffected
References
- https://git.kernel.org/stable/c/58321b4e6e4f0f412069ab27ccdd56292757343a ↗
- https://git.kernel.org/stable/c/74fef68d521150281e36cdaa20e9e1ee3e3aa146 ↗
- https://git.kernel.org/stable/c/ef2ae10a4582bc92b7e944181bbd2f87f3d30f3a ↗
- https://git.kernel.org/stable/c/9c8f31eaae6140ecadec0c07320498a944556de2 ↗
- https://git.kernel.org/stable/c/76e415ea88d20f022ed5cfcf78c50e156a267e91 ↗
- https://git.kernel.org/stable/c/35d4a3cf70a855b50e53189ac2f8463e20a02046 ↗