Description
In the Linux kernel, the following vulnerability has been resolved: mm/memory-failure: fix hugetlb_lock AA deadlock in get_huge_page_for_hwpoison Two concurrent madvise(MADV_HWPOISON) calls on the same hugetlb page can trigger a recursive spinlock self-deadlock (AA deadlock) on hugetlb_lock when racing with a concurrent unmap: thread#0 thread#1 -------- -------- madvise(folio, MADV_HWPOISON) -> poisons the folio successfully madvise(folio, MADV_HWPOISON) unmap(folio) try_memory_failure_hugetlb get_huge_page_for_hwpoison spin_lock_irq(&hugetlb_lock) <- held __get_huge_page_for_hwpoison hugetlb_update_hwpoison() -> MF_HUGETLB_FOLIO_PRE_POISONED goto out: folio_put() refcount: 1 -> 0 free_huge_folio() spin_lock_irqsave(&hugetlb_lock) -> AA DEADLOCK! The out: path in __get_huge_page_for_hwpoison() calls folio_put() to drop the GUP reference while the hugetlb_lock is still held by the hugetlb.c wrapper get_huge_page_for_hwpoison(). If concurrent unmap has released the page table mapping reference, folio_put() drops the folio refcount to zero, triggering free_huge_folio() which attempts to re-acquire the non-recursive hugetlb_lock. Fix this by moving hugetlb_lock acquisition from the hugetlb.c wrapper into get_huge_page_for_hwpoison(). Place spin_unlock_irq() before the folio_put() at the out: label so the folio is always released outside the lock. [akpm@linux-foundation.org: fix race, rename label per Miaohe]
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
405ce051236cc65b30bbfe490b28ce60ae6aed85 to < fc3ff42cb0cbf947e4600ae9761c3783760050e2affected405ce051236cc65b30bbfe490b28ce60ae6aed85 to < 77b73b54801ae7137479c141fd0473a491c1dc48affected405ce051236cc65b30bbfe490b28ce60ae6aed85 to < a33bfed648c10f5a1519981dbfad80841191edc8affected405ce051236cc65b30bbfe490b28ce60ae6aed85 to < dd77a83915b07e2b0205adb284f08b39ae31dc4baffected405ce051236cc65b30bbfe490b28ce60ae6aed85 to < bf7ba8f96c258c30393814491930ae4ecdc5fe5eaffected405ce051236cc65b30bbfe490b28ce60ae6aed85 to < 3c2d42b8ee345b17a4ba56b0f6492d1ff4c1178eaffected62d1655b922958826b7ec22682c3141746f75064affected5.15.54 to < 5.16affected
Linux Linux
Default version status: affected
5.18affected0 to < 5.18unaffected6.1.176 to ≤ 6.1.*unaffected6.6.143 to ≤ 6.6.*unaffected6.12.94 to ≤ 6.12.*unaffected6.18.36 to ≤ 6.18.*unaffected7.0.13 to ≤ 7.0.*unaffected7.1 to ≤ *unaffected
References
- https://git.kernel.org/stable/c/fc3ff42cb0cbf947e4600ae9761c3783760050e2 ↗
- https://git.kernel.org/stable/c/77b73b54801ae7137479c141fd0473a491c1dc48 ↗
- https://git.kernel.org/stable/c/a33bfed648c10f5a1519981dbfad80841191edc8 ↗
- https://git.kernel.org/stable/c/dd77a83915b07e2b0205adb284f08b39ae31dc4b ↗
- https://git.kernel.org/stable/c/bf7ba8f96c258c30393814491930ae4ecdc5fe5e ↗
- https://git.kernel.org/stable/c/3c2d42b8ee345b17a4ba56b0f6492d1ff4c1178e ↗