Description
In the Linux kernel, the following vulnerability has been resolved: fsnotify: fix inode reference leak in fsnotify_recalc_mask() fsnotify_recalc_mask() fails to handle the return value of __fsnotify_recalc_mask(), which may return an inode pointer that needs to be released via fsnotify_drop_object() when the connector's HAS_IREF flag transitions from set to cleared. This manifests as a hung task with the following call trace: INFO: task umount:1234 blocked for more than 120 seconds. Call Trace: __schedule schedule fsnotify_sb_delete generic_shutdown_super kill_anon_super cleanup_mnt task_work_run do_exit do_group_exit The race window that triggers the iref leak: Thread A (adding mark) Thread B (removing mark) ────────────────────── ──────────────────────── fsnotify_add_mark_locked(): fsnotify_add_mark_list(): spin_lock(conn->lock) add mark_B(evictable) to list spin_unlock(conn->lock) return /* ---- gap: no lock held ---- */ fsnotify_detach_mark(mark_A): spin_lock(mark_A->lock) clear ATTACHED flag on mark_A spin_unlock(mark_A->lock) fsnotify_put_mark(mark_A) fsnotify_recalc_mask(): spin_lock(conn->lock) __fsnotify_recalc_mask(): /* mark_A skipped: ATTACHED cleared */ /* only mark_B(evictable) remains */ want_iref = false has_iref = true /* not yet cleared */ -> HAS_IREF transitions true -> false -> returns inode pointer spin_unlock(conn->lock) /* BUG: return value discarded! * iput() and fsnotify_put_sb_watched_objects() * are never called */ Fix this by deferring the transition true -> false of HAS_IREF flag from fsnotify_recalc_mask() (Thread A) to fsnotify_put_mark() (thread B).
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
c3638b5b13740fa31762d414bbce8b7a694e582a to < ba4d88bfd58739698a9bd2309659c9cc26acf7f7affectedc3638b5b13740fa31762d414bbce8b7a694e582a to < 926ec3937b28d30c08427053c8d8af7f9e086d82affectedc3638b5b13740fa31762d414bbce8b7a694e582a to < 8c8afa6444e6bdc145d2bf2f3aeeca6da3e36b42affectedc3638b5b13740fa31762d414bbce8b7a694e582a to < b740cc86816bbc87902ae9db74cd21abde3c8d63affectedc3638b5b13740fa31762d414bbce8b7a694e582a to < 5c80289503da3658e3df80280598c68d181eadbdaffectedc3638b5b13740fa31762d414bbce8b7a694e582a to < 4aca914ac152f5d055ddcb36704d1e539ac08977affectedff34ebaa6f6dc1eebce6a8d6f12a1566f33d00feaffected4f145b67c075324b13d6ae7d5abb6e7a1dbac26daffected5.10.220 to < 5.11affected5.15.154 to < 5.16affected
Linux Linux
Default version status: affected
5.19affected0 to < 5.19unaffected6.1.191 to ≤ 6.1.*unaffected6.6.160 to ≤ 6.6.*unaffected6.12.91 to ≤ 6.12.*unaffected6.18.33 to ≤ 6.18.*unaffected7.0.10 to ≤ 7.0.*unaffected7.1 to ≤ *unaffected
References
- https://git.kernel.org/stable/c/ba4d88bfd58739698a9bd2309659c9cc26acf7f7 ↗
- https://git.kernel.org/stable/c/926ec3937b28d30c08427053c8d8af7f9e086d82 ↗
- https://git.kernel.org/stable/c/8c8afa6444e6bdc145d2bf2f3aeeca6da3e36b42 ↗
- https://git.kernel.org/stable/c/b740cc86816bbc87902ae9db74cd21abde3c8d63 ↗
- https://git.kernel.org/stable/c/5c80289503da3658e3df80280598c68d181eadbd ↗
- https://git.kernel.org/stable/c/4aca914ac152f5d055ddcb36704d1e539ac08977 ↗