Description
In the Linux kernel, the following vulnerability has been resolved: ext4: fix mb_cache_entry's e_refcnt leak in ext4_xattr_block_cache_find() Syzbot reports a warning as follows: ============================================ WARNING: CPU: 0 PID: 5075 at fs/mbcache.c:419 mb_cache_destroy+0x224/0x290 Modules linked in: CPU: 0 PID: 5075 Comm: syz-executor199 Not tainted 6.9.0-rc6-gb947cc5bf6d7 RIP: 0010:mb_cache_destroy+0x224/0x290 fs/mbcache.c:419 Call Trace: <TASK> ext4_put_super+0x6d4/0xcd0 fs/ext4/super.c:1375 generic_shutdown_super+0x136/0x2d0 fs/super.c:641 kill_block_super+0x44/0x90 fs/super.c:1675 ext4_kill_sb+0x68/0xa0 fs/ext4/super.c:7327 [...] ============================================ This is because when finding an entry in ext4_xattr_block_cache_find(), if ext4_sb_bread() returns -ENOMEM, the ce's e_refcnt, which has already grown in the __entry_find(), won't be put away, and eventually trigger the above issue in mb_cache_destroy() due to reference count leakage. So call mb_cache_entry_put() on the -ENOMEM error branch as a quick fix.
Affected products
Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.
Linux Linux
Default version status: unaffected
b878c8a7f08f0c225b6a46ba1ac867e9c5d17807 to < 9ad75e78747b5a50dc5a52f0f8e92e920a653f16affectedfb265c9cb49e2074ddcdd4de99728aefdd3b3592 to < 896a7e7d0d555ad8b2b46af0c2fa7de7467f9483affectedfb265c9cb49e2074ddcdd4de99728aefdd3b3592 to < 76dc776153a47372719d664e0fc50d6355791abbaffectedfb265c9cb49e2074ddcdd4de99728aefdd3b3592 to < 681ff9a09accd8a4379f8bd30b7a1641ee19bb3eaffectedfb265c9cb49e2074ddcdd4de99728aefdd3b3592 to < e941b712e758f615d311946bf98216e79145ccd9affectedfb265c9cb49e2074ddcdd4de99728aefdd3b3592 to < a95df6f04f2c37291adf26a74205cde0314d4577affectedfb265c9cb49e2074ddcdd4de99728aefdd3b3592 to < b37c0edef4e66fb21a2fbc211471195a383e5ab8affectedfb265c9cb49e2074ddcdd4de99728aefdd3b3592 to < 0c0b4a49d3e7f49690a6827a41faeffad5df7e21affected9da1f6d06b7a6d068e68fcfd7cbbf6b586d888e1affected81313ed2c705d958744882a269bf4a5e3ddec95eaffected4.19.14 to < 4.19.316affected4.14.92 to < 4.15affected4.20.1 to < 4.21affected
Linux Linux
Default version status: affected
5.0affected0 to < 5.0unaffected4.19.316 to ≤ 4.19.*unaffected5.4.278 to ≤ 5.4.*unaffected5.10.219 to ≤ 5.10.*unaffected5.15.161 to ≤ 5.15.*unaffected6.1.94 to ≤ 6.1.*unaffected6.6.34 to ≤ 6.6.*unaffected6.9.5 to ≤ 6.9.*unaffected6.10 to ≤ *unaffected
References
- https://git.kernel.org/stable/c/9ad75e78747b5a50dc5a52f0f8e92e920a653f16 ↗
- https://git.kernel.org/stable/c/896a7e7d0d555ad8b2b46af0c2fa7de7467f9483 ↗
- https://git.kernel.org/stable/c/76dc776153a47372719d664e0fc50d6355791abb ↗
- https://git.kernel.org/stable/c/681ff9a09accd8a4379f8bd30b7a1641ee19bb3e ↗
- https://git.kernel.org/stable/c/e941b712e758f615d311946bf98216e79145ccd9 ↗
- https://git.kernel.org/stable/c/a95df6f04f2c37291adf26a74205cde0314d4577 ↗
- https://git.kernel.org/stable/c/b37c0edef4e66fb21a2fbc211471195a383e5ab8 ↗
- https://git.kernel.org/stable/c/0c0b4a49d3e7f49690a6827a41faeffad5df7e21 ↗