Skip to content
CVE PROGRAM SOURCE RECORD5.5 Medium

CVE-2024-35973

geneve: fix header validation in geneve[6]_xmit_skb

Read JSON ↗CVE.org ↗
Status
Published
Published
Updated
Assigning organization
Linux

Description

In the Linux kernel, the following vulnerability has been resolved: geneve: fix header validation in geneve[6]_xmit_skb syzbot is able to trigger an uninit-value in geneve_xmit() [1] Problem : While most ip tunnel helpers (like ip_tunnel_get_dsfield()) uses skb_protocol(skb, true), pskb_inet_may_pull() is only using skb->protocol. If anything else than ETH_P_IPV6 or ETH_P_IP is found in skb->protocol, pskb_inet_may_pull() does nothing at all. If a vlan tag was provided by the caller (af_packet in the syzbot case), the network header might not point to the correct location, and skb linear part could be smaller than expected. Add skb_vlan_inet_prepare() to perform a complete mac validation. Use this in geneve for the moment, I suspect we need to adopt this more broadly. v4 - Jakub reported v3 broke l2_tos_ttl_inherit.sh selftest - Only call __vlan_get_protocol() for vlan types. v2,v3 - Addressed Sabrina comments on v1 and v2 [1] BUG: KMSAN: uninit-value in geneve_xmit_skb drivers/net/geneve.c:910 [inline] BUG: KMSAN: uninit-value in geneve_xmit+0x302d/0x5420 drivers/net/geneve.c:1030 geneve_xmit_skb drivers/net/geneve.c:910 [inline] geneve_xmit+0x302d/0x5420 drivers/net/geneve.c:1030 __netdev_start_xmit include/linux/netdevice.h:4903 [inline] netdev_start_xmit include/linux/netdevice.h:4917 [inline] xmit_one net/core/dev.c:3531 [inline] dev_hard_start_xmit+0x247/0xa20 net/core/dev.c:3547 __dev_queue_xmit+0x348d/0x52c0 net/core/dev.c:4335 dev_queue_xmit include/linux/netdevice.h:3091 [inline] packet_xmit+0x9c/0x6c0 net/packet/af_packet.c:276 packet_snd net/packet/af_packet.c:3081 [inline] packet_sendmsg+0x8bb0/0x9ef0 net/packet/af_packet.c:3113 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x30f/0x380 net/socket.c:745 __sys_sendto+0x685/0x830 net/socket.c:2191 __do_sys_sendto net/socket.c:2203 [inline] __se_sys_sendto net/socket.c:2199 [inline] __x64_sys_sendto+0x125/0x1d0 net/socket.c:2199 do_syscall_64+0xd5/0x1f0 entry_SYSCALL_64_after_hwframe+0x6d/0x75 Uninit was created at: slab_post_alloc_hook mm/slub.c:3804 [inline] slab_alloc_node mm/slub.c:3845 [inline] kmem_cache_alloc_node+0x613/0xc50 mm/slub.c:3888 kmalloc_reserve+0x13d/0x4a0 net/core/skbuff.c:577 __alloc_skb+0x35b/0x7a0 net/core/skbuff.c:668 alloc_skb include/linux/skbuff.h:1318 [inline] alloc_skb_with_frags+0xc8/0xbf0 net/core/skbuff.c:6504 sock_alloc_send_pskb+0xa81/0xbf0 net/core/sock.c:2795 packet_alloc_skb net/packet/af_packet.c:2930 [inline] packet_snd net/packet/af_packet.c:3024 [inline] packet_sendmsg+0x722d/0x9ef0 net/packet/af_packet.c:3113 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x30f/0x380 net/socket.c:745 __sys_sendto+0x685/0x830 net/socket.c:2191 __do_sys_sendto net/socket.c:2203 [inline] __se_sys_sendto net/socket.c:2199 [inline] __x64_sys_sendto+0x125/0x1d0 net/socket.c:2199 do_syscall_64+0xd5/0x1f0 entry_SYSCALL_64_after_hwframe+0x6d/0x75 CPU: 0 PID: 5033 Comm: syz-executor346 Not tainted 6.9.0-rc1-syzkaller-00005-g928a87efa423 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024

Affected products

Version statuses are supplied by the assigning organization. Consult the original record for detailed ranges and platform conditions.

Linux Linux

Default version status: unaffected

  • 35385daa8db320d2d9664930c28e732578b0d7de to < 43be590456e1f3566054ce78ae2dbb68cbe1a536affected
  • 6f92124d74419797fadfbcd5b7a72c384a6413ad to < d3adf11d7993518a39bd02b383cfe657ccc0023caffected
  • 71ad9260c001b217d704cda88ecea251b2d367da to < 10204df9beda4978bd1d0c2db0d8375bfb03b915affected
  • d13f048dd40e8577260cd43faea8ec9b77520197 to < 3c1ae6de74e3d2d6333d29a2d3e13e6094596c79affected
  • d13f048dd40e8577260cd43faea8ec9b77520197 to < 4a1b65d1e55d53b397cb27014208be1e04172670affected
  • d13f048dd40e8577260cd43faea8ec9b77520197 to < 190d9efa5773f26d6f334b1b8be282c4fa13fd5eaffected
  • d13f048dd40e8577260cd43faea8ec9b77520197 to < 357163fff3a6e48fe74745425a32071ec9caf852affected
  • d13f048dd40e8577260cd43faea8ec9b77520197 to < d8a6213d70accb403b82924a1c229e733433a5efaffected
  • 9a51e36ebf433adf59c051bec33f5aa54640bb4daffected
  • 21815f28af8081b258552c111774ff320cf38d38affected
  • 4.19.191 to < 4.19.313affected
  • 5.4.119 to < 5.4.275affected
  • 5.10.37 to < 5.10.216affected
  • 5.11.21 to < 5.12affected
  • 5.12.4 to < 5.13affected

Linux Linux

Default version status: affected

  • 5.13affected
  • 0 to < 5.13unaffected
  • 4.19.313 to ≤ 4.19.*unaffected
  • 5.4.275 to ≤ 5.4.*unaffected
  • 5.10.216 to ≤ 5.10.*unaffected
  • 5.15.156 to ≤ 5.15.*unaffected
  • 6.1.87 to ≤ 6.1.*unaffected
  • 6.6.28 to ≤ 6.6.*unaffected
  • 6.8.7 to ≤ 6.8.*unaffected
  • 6.9 to ≤ *unaffected

References